From: HIMANGI SARAOGI <himangi774@gmail.com>
Date: Tue, 8 Jul 2014 22:21:41 +0000 (+0530)
Subject: Btrfs: use BUG_ON
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=14586651ed8f067e4add72c739f0bd2c2620fd9d;p=openwrt%2Fstaging%2Fblogic.git

Btrfs: use BUG_ON

Use BUG_ON(x) rather than if(x) BUG();

The semantic patch that fixes this problem is as follows:

// <smpl>
@@ identifier x; @@
-if (x) BUG();
+BUG_ON(x);
// </smpl>

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Chris Mason <clm@fb.com>
---

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 48c357223e56..7f25ff1c3854 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2677,8 +2677,8 @@ again:
 						   found_key.offset);
 			if (ret == -ENOSPC)
 				failed++;
-			else if (ret)
-				BUG();
+			else
+				BUG_ON(ret);
 		}
 
 		if (found_key.offset == 0)