From: David Dillow Date: Sun, 24 Oct 2010 10:20:20 +0000 (+0000) Subject: typhoon: wait for RX mode commands to finish X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=154ccd82e1b871ca012e781e01566128754d8c5f;p=openwrt%2Fstaging%2Fblogic.git typhoon: wait for RX mode commands to finish When adding VLAN devices, we can get several calls to typhoon_set_rx_mode() in quick succession. Because we didn't wait for the commands to complete, we could run out of command descriptors and fail to set the RX mode. Signed-off-by: David Dillow Signed-off-by: David S. Miller --- diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c index 1cc67138adbf..5957d4ecd86b 100644 --- a/drivers/net/typhoon.c +++ b/drivers/net/typhoon.c @@ -936,7 +936,7 @@ typhoon_set_rx_mode(struct net_device *dev) filter |= TYPHOON_RX_FILTER_MCAST_HASH; } - INIT_COMMAND_NO_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER); + INIT_COMMAND_WITH_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER); xp_cmd.parm1 = filter; typhoon_issue_command(tp, 1, &xp_cmd, 0, NULL); }