From: Gabor Juhos Date: Thu, 27 Sep 2012 20:05:42 +0000 (+0000) Subject: ar71xx: avoid possible NULL pointer dereference in ath79_init_{,local}_mac X-Git-Tag: reboot~12779 X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=170cd7a19a76556e3e07eec82b3848b552f007b8;p=openwrt%2Fstaging%2Fchunkeey.git ar71xx: avoid possible NULL pointer dereference in ath79_init_{,local}_mac SVN-Revision: 33575 --- diff --git a/target/linux/ar71xx/files/arch/mips/ath79/dev-eth.c b/target/linux/ar71xx/files/arch/mips/ath79/dev-eth.c index d2d0ee87f0..4487958bc7 100644 --- a/target/linux/ar71xx/files/arch/mips/ath79/dev-eth.c +++ b/target/linux/ar71xx/files/arch/mips/ath79/dev-eth.c @@ -992,7 +992,10 @@ void __init ath79_init_mac(unsigned char *dst, const unsigned char *src, { int t; - if (!is_valid_ether_addr(src)) { + if (!dst) + return; + + if (!src || !is_valid_ether_addr(src)) { memset(dst, '\0', ETH_ALEN); return; } @@ -1012,7 +1015,10 @@ void __init ath79_init_local_mac(unsigned char *dst, const unsigned char *src) { int i; - if (!is_valid_ether_addr(src)) { + if (!dst) + return; + + if (!src || !is_valid_ether_addr(src)) { memset(dst, '\0', ETH_ALEN); return; }