From: Jakub Kicinski Date: Sat, 15 Mar 2014 14:55:11 +0000 (+0000) Subject: ixgbe: remove redundant if clause from PTP work X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=181e7d5d7bd7747e882e3ca89ecbf0fc3e72d0da;p=openwrt%2Fstaging%2Fblogic.git ixgbe: remove redundant if clause from PTP work ptp_tx_skb is always set before work is scheduled, work is cancelled before ptp_tx_skb is set to NULL. PTP work cannot ever see ptp_tx_skb set to NULL. Signed-off-by: Jakub Kicinski Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher --- diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c index 44ac9aef6a8d..8b527d79d429 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c @@ -512,10 +512,6 @@ static void ixgbe_ptp_tx_hwtstamp_work(struct work_struct *work) IXGBE_PTP_TX_TIMEOUT); u32 tsynctxctl; - /* we have to have a valid skb */ - if (!adapter->ptp_tx_skb) - return; - if (timeout) { dev_kfree_skb_any(adapter->ptp_tx_skb); adapter->ptp_tx_skb = NULL;