From: Alexander Stein Date: Tue, 11 Nov 2014 08:08:43 +0000 (+0100) Subject: gpio: mcp23s08: Do not free unrequested interrupt X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=1c649f4c8649050947b67358467b839e950abd14;p=openwrt%2Fstaging%2Fblogic.git gpio: mcp23s08: Do not free unrequested interrupt If devm_request_threaded_irq fails for some reason we call mcp23s08_irq_teardown afterwards. Do not free the unrequested interrupt in this case. free_irq can also be omitted for the error free case because we use devm_request_threaded_irq. Signed-off-by: Alexander Stein Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c index 468d10d2ac1e..1ac7de85da8b 100644 --- a/drivers/gpio/gpio-mcp23s08.c +++ b/drivers/gpio/gpio-mcp23s08.c @@ -514,8 +514,6 @@ static void mcp23s08_irq_teardown(struct mcp23s08 *mcp) { unsigned int irq, i; - free_irq(mcp->irq, mcp); - for (i = 0; i < mcp->chip.ngpio; i++) { irq = irq_find_mapping(mcp->irq_domain, i); if (irq > 0)