From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 21 Feb 2012 21:30:25 +0000 (+0000)
Subject: hso: memsetting wrong data in hso_get_count()
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=22ad7499bc9297e47c8779bf5523694f28338499;p=openwrt%2Fstaging%2Fblogic.git

hso: memsetting wrong data in hso_get_count()

The intent was to clear out the icount struct here, but we accidentally
clear stack memory instead.  It probably will lead to a NULL dereference
right away.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 304fe78ff60e..e1324b4a0f66 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -1632,7 +1632,7 @@ static int hso_get_count(struct tty_struct *tty,
 	struct hso_serial *serial = get_serial_by_tty(tty);
 	struct hso_tiocmget  *tiocmget = serial->tiocmget;
 
-	memset(&icount, 0, sizeof(struct serial_icounter_struct));
+	memset(icount, 0, sizeof(struct serial_icounter_struct));
 
 	if (!tiocmget)
 		 return -ENOENT;