From: Tejun Heo <tj@kernel.org>
Date: Tue, 14 May 2013 20:52:31 +0000 (-0700)
Subject: blk-throttle: remove spurious throtl_enqueue_tg() call from throtl_select_dispatch()
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=2db6314c213bb21102dd1dad06cfda6a8682d624;p=openwrt%2Fstaging%2Fblogic.git

blk-throttle: remove spurious throtl_enqueue_tg() call from throtl_select_dispatch()

throtl_select_dispatch() calls throtl_enqueue_tg() right after
tg_update_disptime(), which always calls the function anyway.  The
call is, while harmless, unnecessary.  Remove it.

This patch doesn't introduce any behavior difference.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
---

diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 31146225f3d0..3960787358b6 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -816,10 +816,8 @@ static int throtl_select_dispatch(struct throtl_data *td, struct bio_list *bl)
 
 		nr_disp += throtl_dispatch_tg(td, tg, bl);
 
-		if (tg->nr_queued[0] || tg->nr_queued[1]) {
+		if (tg->nr_queued[0] || tg->nr_queued[1])
 			tg_update_disptime(td, tg);
-			throtl_enqueue_tg(td, tg);
-		}
 
 		if (nr_disp >= throtl_quantum)
 			break;