From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 3 Dec 2018 14:51:43 +0000 (+0300)
Subject: clk: mmp: Off by one in mmp_clk_add()
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=2e85c57493e391b93445c1e0d530b36b95becc64;p=openwrt%2Fstaging%2Fblogic.git

clk: mmp: Off by one in mmp_clk_add()

The > comparison should be >= or we write one element beyond the end of
the unit->clk_table[] array.

(The unit->clk_table[] array is allocated in the mmp_clk_init() function
and it has unit->nr_clks elements).

Fixes: 4661fda10f8b ("clk: mmp: add basic support functions for DT support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---

diff --git a/drivers/clk/mmp/clk.c b/drivers/clk/mmp/clk.c
index ad8d483a35cd..ca7d37e2c7be 100644
--- a/drivers/clk/mmp/clk.c
+++ b/drivers/clk/mmp/clk.c
@@ -183,7 +183,7 @@ void mmp_clk_add(struct mmp_clk_unit *unit, unsigned int id,
 		pr_err("CLK %d has invalid pointer %p\n", id, clk);
 		return;
 	}
-	if (id > unit->nr_clks) {
+	if (id >= unit->nr_clks) {
 		pr_err("CLK %d is invalid\n", id);
 		return;
 	}