From: Felix Fietkau <nbd@openwrt.org>
Date: Sat, 30 Nov 2013 17:17:55 +0000 (+0100)
Subject: wireless: fix use-after-free bug
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=37769eb666aa614b76df9b537db35c2c70e3ac7a;p=project%2Fnetifd.git

wireless: fix use-after-free bug

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---

diff --git a/wireless.c b/wireless.c
index 23bedcc..daa4df7 100644
--- a/wireless.c
+++ b/wireless.c
@@ -495,6 +495,7 @@ vif_update(struct vlist_tree *tree, struct vlist_node *node_new,
 		wdev = vif_new->wdev;
 
 	if (vif_old && vif_new) {
+		vif_old->section = vif_new->section;
 		if (blob_attr_equal(vif_old->config, vif_new->config)) {
 			free(vif_new);
 			return;
@@ -505,7 +506,6 @@ vif_update(struct vlist_tree *tree, struct vlist_node *node_new,
 		vif_old->config = blob_memdup(vif_new->config);
 		wireless_interface_init_config(vif_old);
 		free(vif_new);
-		vif_old->section = vif_new->section;
 	} else if (vif_new) {
 		D(WIRELESS, "Create new wireless interface %s on device %s\n", vif_new->name, wdev->name);
 		vif_new->config = blob_memdup(vif_new->config);