From: Johan Hovold Date: Wed, 16 Nov 2016 14:20:37 +0000 (+0100) Subject: of_mdio: fix device reference leak in of_phy_find_device X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=3ae30f4ce65e9d4de274b1472169ab3c27f5c666;p=openwrt%2Fstaging%2Fblogic.git of_mdio: fix device reference leak in of_phy_find_device Make sure to drop the reference taken by bus_find_device() before returning NULL from of_phy_find_device() when the found device is not a PHY. Fixes: 6ed742363b9c ("of: of_mdio: Ensure mdio device is a PHY") Signed-off-by: Johan Hovold Signed-off-by: David S. Miller --- diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index 8f4648383fb2..5a3145a02547 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -292,6 +292,7 @@ struct phy_device *of_phy_find_device(struct device_node *phy_np) mdiodev = to_mdio_device(d); if (mdiodev->flags & MDIO_DEVICE_FLAG_PHY) return to_phy_device(d); + put_device(d); } return NULL;