From: John Crispin <john@openwrt.org>
Date: Fri, 27 Dec 2013 21:15:31 +0000 (+0000)
Subject: firmware-utils: check_magic() in buffalo-lib.c always return 0
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=3f218330d24da8016975443eb6457ab6b7ba367e;p=project%2Ffirmware-utils.git

firmware-utils: check_magic() in buffalo-lib.c always return 0

spotted with cppcheck

Signed-off-by: Etienne CHAMPETIER <etienne.champetier@free.fr>

SVN-Revision: 39171
---

diff --git a/src/buffalo-lib.c b/src/buffalo-lib.c
index 29aee9f..add3a7e 100644
--- a/src/buffalo-lib.c
+++ b/src/buffalo-lib.c
@@ -249,10 +249,10 @@ static uint32_t get_be32(void *data)
 
 static int check_magic(void *magic)
 {
-	if (!memcmp("start", magic, ENC_MAGIC_LEN));
+	if (!memcmp("start", magic, ENC_MAGIC_LEN))
 		return 0;
 
-	if (!memcmp("asar1", magic, ENC_MAGIC_LEN));
+	if (!memcmp("asar1", magic, ENC_MAGIC_LEN))
 		return 0;
 
 	return -1;