From: Gustavo A. R. Silva Date: Thu, 22 Mar 2018 18:21:54 +0000 (-0500) Subject: drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=41e7ccc19c2a52b13b77f2a489a466b140d2d235;p=openwrt%2Fstaging%2Fblogic.git drm/i915/gvt/scheduler: Remove unnecessary NULL checks in sr_oa_regs The checks are misleading and not required [1]. [1] https://lkml.org/lkml/2018/3/19/1792 Addresses-Coverity-ID: 1466017 Cc: Chris Wilson Signed-off-by: Gustavo A. R. Silva Reviewed-by: Chris Wilson Signed-off-by: Zhi Wang --- diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c index 1bd7aa0c694a..d1a8fd88eed9 100644 --- a/drivers/gpu/drm/i915/gvt/scheduler.c +++ b/drivers/gpu/drm/i915/gvt/scheduler.c @@ -97,7 +97,7 @@ static void sr_oa_regs(struct intel_vgpu_workload *workload, i915_mmio_reg_offset(EU_PERF_CNTL6), }; - if (!workload || !reg_state || workload->ring_id != RCS) + if (workload->ring_id != RCS) return; if (save) {