From: H Hartley Sweeten Date: Tue, 26 Mar 2013 17:26:38 +0000 (-0700) Subject: staging: comedi: ni_labpc: simplify labpc_range_is_unipolar() X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=43d092c67740704c9a8d04da2ca070bfca34207a;p=openwrt%2Fstaging%2Fblogic.git staging: comedi: ni_labpc: simplify labpc_range_is_unipolar() As Ian Abbott pointed out, this helper function can be simplified by just checking if the 'min' value is >= 0. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/ni_labpc.c b/drivers/staging/comedi/drivers/ni_labpc.c index a9117f77b9b2..b0ec088a7285 100644 --- a/drivers/staging/comedi/drivers/ni_labpc.c +++ b/drivers/staging/comedi/drivers/ni_labpc.c @@ -320,13 +320,7 @@ static int labpc_counter_set_mode(struct comedi_device *dev, static bool labpc_range_is_unipolar(struct comedi_subdevice *s, unsigned int range) { - const struct comedi_lrange *lrange = s->range_table; - const struct comedi_krange *krange = &lrange->range[range]; - - if (krange->min < 0) - return false; - else - return true; + return s->range_table->range[range].min >= 0; } static int labpc_cancel(struct comedi_device *dev, struct comedi_subdevice *s)