From: Steve French Date: Thu, 11 Apr 2019 18:53:17 +0000 (-0500) Subject: SMB3: Add handling for different FSCTL access flags X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=46e6661963fb5d55952b550f0716bda22e10f1ae;p=openwrt%2Fstaging%2Fblogic.git SMB3: Add handling for different FSCTL access flags DesiredAccess field in SMB3 open request needs to be set differently for READ vs. WRITE ioctls (not just ones that request both). Originally noticed by Pavel Signed-off-by: Steve French Reviewed-by: Ronnie Sahlberg --- diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index ed8c2ba9590b..08ff044fbb4b 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -1389,7 +1389,15 @@ smb2_ioctl_query_info(const unsigned int xid, switch (qi.info_type & FSCTL_DEVICE_ACCESS_MASK) { case FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS: oparms.desired_access = FILE_READ_DATA | FILE_WRITE_DATA | FILE_READ_ATTRIBUTES | SYNCHRONIZE; - ; + break; + case FSCTL_DEVICE_ACCESS_FILE_ANY_ACCESS: + oparms.desired_access = GENERIC_ALL; + break; + case FSCTL_DEVICE_ACCESS_FILE_READ_ACCESS: + oparms.desired_access = GENERIC_READ; + break; + case FSCTL_DEVICE_ACCESS_FILE_WRITE_ACCESS: + oparms.desired_access = GENERIC_WRITE; break; } }