From: Matthias Schiffer Date: Thu, 23 Feb 2017 16:19:41 +0000 (+0100) Subject: vxlan: correctly validate VXLAN ID against VXLAN_N_VID X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=4e37d6911f36545b286d15073f6f2222f840e81c;p=openwrt%2Fstaging%2Fblogic.git vxlan: correctly validate VXLAN ID against VXLAN_N_VID The incorrect check caused an off-by-one error: the maximum VID 0xffffff was unusable. Fixes: d342894c5d2f ("vxlan: virtual extensible lan") Signed-off-by: Matthias Schiffer Acked-by: Jiri Benc Signed-off-by: David S. Miller --- diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 556953f53437..268c2a12e61d 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -2675,7 +2675,7 @@ static int vxlan_validate(struct nlattr *tb[], struct nlattr *data[]) if (data[IFLA_VXLAN_ID]) { __u32 id = nla_get_u32(data[IFLA_VXLAN_ID]); - if (id >= VXLAN_VID_MASK) + if (id >= VXLAN_N_VID) return -ERANGE; }