From: Markus Elfring Date: Thu, 8 Mar 2018 11:46:47 +0000 (+0100) Subject: mfd: abx500-core: Improve two size determinations in abx500_register_ops() X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=5053e3a3383ef3952496146c75e77245e51e9040;p=openwrt%2Fstaging%2Fblogic.git mfd: abx500-core: Improve two size determinations in abx500_register_ops() Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Reviewed-by: Linus Walleij Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/abx500-core.c b/drivers/mfd/abx500-core.c index c8c9d41abcaa..17176e91cbd0 100644 --- a/drivers/mfd/abx500-core.c +++ b/drivers/mfd/abx500-core.c @@ -37,14 +37,12 @@ int abx500_register_ops(struct device *dev, struct abx500_ops *ops) { struct abx500_device_entry *dev_entry; - dev_entry = devm_kzalloc(dev, - sizeof(struct abx500_device_entry), - GFP_KERNEL); + dev_entry = devm_kzalloc(dev, sizeof(*dev_entry), GFP_KERNEL); if (!dev_entry) return -ENOMEM; dev_entry->dev = dev; - memcpy(&dev_entry->ops, ops, sizeof(struct abx500_ops)); + memcpy(&dev_entry->ops, ops, sizeof(*ops)); list_add_tail(&dev_entry->list, &abx500_list); return 0;