From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Tue, 8 May 2018 06:14:15 +0000 (-0400)
Subject: media: i2c: tda1997: Fix an error handling path 'tda1997x_probe()'
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=50a0efae2758687737349707e335ccf2de9007d2;p=openwrt%2Fstaging%2Fblogic.git

media: i2c: tda1997: Fix an error handling path 'tda1997x_probe()'

If 'media_entity_pads_init()' fails, we must free the resources allocated
by 'v4l2_ctrl_handler_init()', as already done in the previous error
handling path.

'goto' the right label to fix it.

Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver")

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---

diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
index 1c5b5f70866f..b697c6f741d1 100644
--- a/drivers/media/i2c/tda1997x.c
+++ b/drivers/media/i2c/tda1997x.c
@@ -2721,7 +2721,7 @@ static int tda1997x_probe(struct i2c_client *client,
 		state->pads);
 	if (ret) {
 		v4l_err(client, "failed entity_init: %d", ret);
-		goto err_free_mutex;
+		goto err_free_handler;
 	}
 
 	ret = v4l2_async_register_subdev(sd);