From: Gustavo A. R. Silva Date: Wed, 31 Jan 2018 04:55:33 +0000 (-0600) Subject: openvswitch: meter: Use 64-bit arithmetic instead of 32-bit X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=5b7789e8fa8f353ad8f2c44de2385cb161b22d32;p=openwrt%2Fstaging%2Fblogic.git openvswitch: meter: Use 64-bit arithmetic instead of 32-bit Add suffix LL to constant 1000 in order to give the compiler complete information about the proper arithmetic to use. Notice that this constant is used in a context that expects an expression of type long long int (64 bits, signed). The expression (band->burst_size + band->rate) * 1000 is currently being evaluated using 32-bit arithmetic. Addresses-Coverity-ID: 1461563 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva Signed-off-by: David S. Miller --- diff --git a/net/openvswitch/meter.c b/net/openvswitch/meter.c index 3fbfc78991ac..04b94281a30b 100644 --- a/net/openvswitch/meter.c +++ b/net/openvswitch/meter.c @@ -488,7 +488,7 @@ bool ovs_meter_execute(struct datapath *dp, struct sk_buff *skb, long long int max_bucket_size; band = &meter->bands[i]; - max_bucket_size = (band->burst_size + band->rate) * 1000; + max_bucket_size = (band->burst_size + band->rate) * 1000LL; band->bucket += delta_ms * band->rate; if (band->bucket > max_bucket_size)