From: Rafał Miłecki Date: Tue, 16 Aug 2022 10:08:51 +0000 (+0200) Subject: cli: drop redundant uci_add_delta_path() call for -P X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=5de3871898e1ef4aec773e4dc9dc18acf52acee4;p=project%2Fuci.git cli: drop redundant uci_add_delta_path() call for -P savedir is always present in the list of delta paths. It's guaranteed by 1. uci_alloc_context() which sets defaults 2. uci_set_savedir() which allows changing savedir Calling uci_add_delta_path() with ctx->savedir argument seems to always return UCI_ERR_DUPLICATE. Fixes: 2b4872345ab2b ("make use of the history path feature in the cli") Cc: Felix Fietkau Signed-off-by: Rafał Miłecki --- diff --git a/cli.c b/cli.c index 2fce39d..b4c4f95 100644 --- a/cli.c +++ b/cli.c @@ -748,7 +748,6 @@ int main(int argc, char **argv) uci_add_delta_path(ctx, optarg); break; case 'P': - uci_add_delta_path(ctx, ctx->savedir); uci_set_savedir(ctx, optarg); flags |= CLI_FLAG_NOCOMMIT; break;