From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 17 Nov 2017 16:21:49 +0000 (+0100)
Subject: OMAPFB: prevent buffer underflow in omapfb_parse_vram_param()
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=5f215d252496543ba22299bccef5062d30d63cfe;p=openwrt%2Fstaging%2Fblogic.git

OMAPFB: prevent buffer underflow in omapfb_parse_vram_param()

We cap the upper bound of "fbnum" but we also need to check for
negatives or make the type unsigned.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---

diff --git a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
index 1d7c012f09db..e08e5664e330 100644
--- a/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
+++ b/drivers/video/fbdev/omap2/omapfb/omapfb-main.c
@@ -1477,7 +1477,7 @@ static int omapfb_alloc_fbmem_display(struct fb_info *fbi, unsigned long size,
 static int omapfb_parse_vram_param(const char *param, int max_entries,
 		unsigned long *sizes, unsigned long *paddrs)
 {
-	int fbnum;
+	unsigned int fbnum;
 	unsigned long size;
 	unsigned long paddr = 0;
 	char *p, *start;