From: Gal Pressman <pressmangal@gmail.com>
Date: Mon, 8 Oct 2018 16:44:03 +0000 (+0300)
Subject: RDMA/mlx5: Remove extraneous error check
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=645ba5970c0766c610920fd5e8dd34e62766af5a;p=openwrt%2Fstaging%2Fblogic.git

RDMA/mlx5: Remove extraneous error check

Remove double error check from create user RQ error flow.

Fixes: 79b20a6c3014 ("IB/mlx5: Add receive Work Queue verbs")
Signed-off-by: Gal Pressman <pressmangal@gmail.com>
Reviewed-by: Majd Dibbiny <majd@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---

diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index fa8e5dc65cb4..829aec3aba8f 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -5587,8 +5587,7 @@ static int prepare_user_rq(struct ib_pd *pd,
 	err = create_user_rq(dev, pd, rwq, &ucmd);
 	if (err) {
 		mlx5_ib_dbg(dev, "err %d\n", err);
-		if (err)
-			return err;
+		return err;
 	}
 
 	rwq->user_index = ucmd.user_index;