From: Dennis Menschel Date: Wed, 21 Oct 2015 21:16:56 +0000 (+0200) Subject: staging: fbtft: fix voltage settings for C-Berry28 X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=646287ba9faececebeffa998a5b75160ec94e090;p=openwrt%2Fstaging%2Fblogic.git staging: fbtft: fix voltage settings for C-Berry28 This patch fixes some internal voltage settings for the C-Berry28 display. The original example source files for the C-Berry28 as provided by its vendor admatec contained six issues where a command parameter's value didn't match its corresponding comment. I've informed admatec about these discrepancies on 2015-08-25. In the meantime, I've assumed the comments to be more reliable than the code, and thus have used these values to write the initial C-Berry28 driver. After having received a reply from admatec on 2015-10-16 that the issues have been fixed in their example code, it has turned out that for the voltages VCOM and AVDD, the code was indeed correct, but the comments were wrong. This patch is meant to fix these two pending mistakes. Signed-off-by: Dennis Menschel Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index d7475d7e8438..071f79bd19f3 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -162,18 +162,18 @@ static int cberry28_init_sequence[] = { /* VDV = 0V */ -1, 0xC4, 0x20, - /* VCOM = 0.875V */ - -1, 0xBB, 0x1F, + /* VCOM = 0.675V */ + -1, 0xBB, 0x17, /* VCOM offset = 0V */ -1, 0xC5, 0x20, /* - * AVDD = 6.6V + * AVDD = 6.8V * AVCL = -4.8V * VDS = 2.3V */ - -1, 0xD0, 0xA4, 0x61, + -1, 0xD0, 0xA4, 0xA1, -1, MIPI_DCS_SET_DISPLAY_ON,