From: H Hartley Sweeten Date: Thu, 8 Oct 2015 17:48:27 +0000 (-0700) Subject: staging: comedi: dt3000: tidy up memory subdevice init X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=649c836ea37d30fe5e7c6548ffd22eacec9a29e7;p=openwrt%2Fstaging%2Fblogic.git staging: comedi: dt3000: tidy up memory subdevice init Remove the unnecessary 'len_chanlist' initialization. This member is only used by subdevices that support async commands. For aesthetics, reorder the initialization a bit. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/dt3000.c b/drivers/staging/comedi/drivers/dt3000.c index 5d1e4bbc5909..0610875f9f1c 100644 --- a/drivers/staging/comedi/drivers/dt3000.c +++ b/drivers/staging/comedi/drivers/dt3000.c @@ -704,15 +704,14 @@ static int dt3000_auto_attach(struct comedi_device *dev, s->insn_config = dt3k_dio_insn_config; s->insn_bits = dt3k_dio_insn_bits; + /* Memory subdevice */ s = &dev->subdevices[3]; - /* mem subsystem */ s->type = COMEDI_SUBD_MEMORY; s->subdev_flags = SDF_READABLE; s->n_chan = 0x1000; - s->insn_read = dt3k_mem_insn_read; s->maxdata = 0xff; - s->len_chanlist = 1; s->range_table = &range_unknown; + s->insn_read = dt3k_mem_insn_read; return 0; }