From: Eric Sandeen Date: Thu, 15 Nov 2012 03:22:05 +0000 (-0500) Subject: ext4: init pagevec in ext4_da_block_invalidatepages X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=66bea92c69477a75a5d37b9bfed5773c92a3c4b4;p=openwrt%2Fstaging%2Fblogic.git ext4: init pagevec in ext4_da_block_invalidatepages ext4_da_block_invalidatepages is missing a pagevec_init(), which means that pvec->cold contains random garbage. This affects whether the page goes to the front or back of the LRU when ->cold makes it to free_hot_cold_page() Reviewed-by: Lukas Czerner Reviewed-by: Carlos Maiolino Signed-off-by: Eric Sandeen Signed-off-by: "Theodore Ts'o" Cc: stable@vger.kernel.org --- diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 7f9ccc1381a9..52f7ff2f2e7e 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1482,6 +1482,7 @@ static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd) last = end << (PAGE_CACHE_SHIFT - inode->i_blkbits); ext4_es_remove_extent(inode, start, last - start + 1); + pagevec_init(&pvec, 0); while (index <= end) { nr_pages = pagevec_lookup(&pvec, mapping, index, PAGEVEC_SIZE); if (nr_pages == 0)