From: Greg Kroah-Hartman Date: Wed, 2 Sep 2009 03:12:58 +0000 (-0700) Subject: Staging: hv: warn the world of a bug in the release function X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=689bf406829c8a5e44ebf8fc8918b77b3806ee48;p=openwrt%2Fstaging%2Fblogic.git Staging: hv: warn the world of a bug in the release function All device release functions need to do something, if not, it's a bug. By merely providing an "empty" release function, it gets the kernel to shut up, but that's not solving the problem at all. Stick a big fat WARN_ON(1); in there to get people's attention. Cc: Hank Janssen Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c index 4462d5bb87e7..cc81ffd7e8a8 100644 --- a/drivers/staging/hv/vmbus_drv.c +++ b/drivers/staging/hv/vmbus_drv.c @@ -965,6 +965,11 @@ Desc: Final callback release of the vmbus root device static void vmbus_bus_release(struct device *device) { DPRINT_ENTER(VMBUS_DRV); + /* FIXME */ + /* Empty release functions are a bug, or a major sign + * of a problem design, this MUST BE FIXED! */ + dev_err(device, "%s needs to be fixed!\n", __func__); + WARN_ON(1); DPRINT_EXIT(VMBUS_DRV); }