From: Vasily Averin Date: Wed, 7 Nov 2018 16:10:21 +0000 (-0500) Subject: ext4: fix buffer leak in ext4_xattr_move_to_block() on error path X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=6bdc9977fcdedf47118d2caf7270a19f4b6d8a8f;p=openwrt%2Fstaging%2Fblogic.git ext4: fix buffer leak in ext4_xattr_move_to_block() on error path Fixes: 3f2571c1f91f ("ext4: factor out xattr moving") Fixes: 6dd4ee7cab7e ("ext4: Expand extra_inodes space per ...") Reviewed-by: Jan Kara Signed-off-by: Vasily Averin Signed-off-by: Theodore Ts'o Cc: stable@kernel.org # 2.6.23 --- diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 07b9a335c8eb..5c9bc0d85cc0 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -2617,6 +2617,8 @@ out: kfree(buffer); if (is) brelse(is->iloc.bh); + if (bs) + brelse(bs->bh); kfree(is); kfree(bs);