From: Oleg Nesterov Date: Wed, 17 Oct 2007 06:27:00 +0000 (-0700) Subject: wait_task_stopped/continued: remove unneeded p->signal != NULL check X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=715015e8da37c4d13e234def054bcbea116297e9;p=openwrt%2Fstaging%2Fblogic.git wait_task_stopped/continued: remove unneeded p->signal != NULL check The child was found on ->children list under tasklist_lock, it must have a valid ->signal. __exit_signal() both removes the task from parent->children and clears ->signal "atomically" under write_lock(tasklist). Remove unneeded checks. Signed-off-by: Oleg Nesterov Acked-by: Roland McGrath Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/kernel/exit.c b/kernel/exit.c index b27a3dcde671..25f6805be5fe 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1322,7 +1322,7 @@ static int wait_task_stopped(struct task_struct *p, int delayed_group_leader, if (!p->exit_code) return 0; if (delayed_group_leader && !(p->ptrace & PT_PTRACED) && - p->signal && p->signal->group_stop_count > 0) + p->signal->group_stop_count > 0) /* * A group stop is in progress and this is the group leader. * We won't report until all threads have stopped. @@ -1436,9 +1436,6 @@ static int wait_task_continued(struct task_struct *p, int noreap, pid_t pid; uid_t uid; - if (unlikely(!p->signal)) - return 0; - if (!(p->signal->flags & SIGNAL_STOP_CONTINUED)) return 0;