From: Colin Ian King <colin.king@canonical.com>
Date: Fri, 3 Nov 2017 09:20:47 +0000 (+0000)
Subject: xen/pvcalls: remove redundant check for irq >= 0
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=773aaadcd474d0a4f85915787118891d47b60983;p=openwrt%2Fstaging%2Fblogic.git

xen/pvcalls: remove redundant check for irq >= 0

This is a moot point, but irq is always less than zero at the label
out_error, so the check for irq >= 0 is redundant and can be removed.

Detected by CoverityScan, CID#1460371 ("Logically dead code")

Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---

diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 60a0ad81d4cf..2925b2f095ed 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -351,9 +351,7 @@ static int create_active(struct sock_mapping *map, int *evtchn)
 	return 0;
 
 out_error:
-	if (irq >= 0)
-		unbind_from_irqhandler(irq, map);
-	else if (*evtchn >= 0)
+	if (*evtchn >= 0)
 		xenbus_free_evtchn(pvcalls_front_dev, *evtchn);
 	kfree(map->active.data.in);
 	kfree(map->active.ring);