From: Laurent Navet Date: Mon, 3 Dec 2012 13:20:25 +0000 (+0100) Subject: staging: line6: Use kmemdup rather than duplicating its implementation X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=77ecb6fe6dce7a726b374665fe1b74cc5cac30fd;p=openwrt%2Fstaging%2Fblogic.git staging: line6: Use kmemdup rather than duplicating its implementation staging: line6: driver.c The semantic patch that makes this output is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Laurent Navet Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c index 1e4ce50069a9..71c2a572b5cc 100644 --- a/drivers/staging/line6/driver.c +++ b/drivers/staging/line6/driver.c @@ -307,14 +307,13 @@ int line6_version_request_async(struct usb_line6 *line6) char *buffer; int retval; - buffer = kmalloc(sizeof(line6_request_version), GFP_ATOMIC); + buffer = kmemdup(line6_request_version, + sizeof(line6_request_version), GFP_ATOMIC); if (buffer == NULL) { dev_err(line6->ifcdev, "Out of memory"); return -ENOMEM; } - memcpy(buffer, line6_request_version, sizeof(line6_request_version)); - retval = line6_send_raw_message_async(line6, buffer, sizeof(line6_request_version)); kfree(buffer);