From: akpm@osdl.org Date: Sat, 16 Apr 2005 22:23:57 +0000 (-0700) Subject: [PATCH] arm: add comment about dma_supported() X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=7a228aaa879c119c9fb9b9d7e062ac13cb1a9079;p=openwrt%2Fstaging%2Fblogic.git [PATCH] arm: add comment about dma_supported() ) From: Russell King The ARM dma_supported() is rather basic, and I don't think it takes into account everything that it should do (eg, whether the mask agrees with what we'd return for GFP_DMA allocations). Note this. Signed-off-by: Russell King Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/include/asm-arm/dma-mapping.h b/include/asm-arm/dma-mapping.h index 925d016dd4b5..d62ade4e4cbb 100644 --- a/include/asm-arm/dma-mapping.h +++ b/include/asm-arm/dma-mapping.h @@ -21,6 +21,9 @@ extern void consistent_sync(void *kaddr, size_t size, int rw); * properly. For example, if your device can only drive the low 24-bits * during bus mastering, then you would pass 0x00ffffff as the mask * to this function. + * + * FIXME: This should really be a platform specific issue - we should + * return false if GFP_DMA allocations may not satisfy the supplied 'mask'. */ static inline int dma_supported(struct device *dev, u64 mask) {