From: Guenter Roeck Date: Wed, 19 Dec 2012 02:16:08 +0000 (-0800) Subject: hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=86266ca0e23b2b8e7e38edda1675cd085a9abc14;p=openwrt%2Fstaging%2Fblogic.git hwmon: (emc6w201) Fix DIV_ROUND_CLOSEST problem with unsigned divisors Result of DIV_ROUND_CLOSEST is undefined for negative dividends if the divisor variable type is unsigned. Fix by declaring divisor as signed variable. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare --- diff --git a/drivers/hwmon/emc6w201.c b/drivers/hwmon/emc6w201.c index a98c917b5888..789bd4fb329b 100644 --- a/drivers/hwmon/emc6w201.c +++ b/drivers/hwmon/emc6w201.c @@ -187,7 +187,7 @@ static struct emc6w201_data *emc6w201_update_device(struct device *dev) * Sysfs callback functions */ -static const u16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 }; +static const s16 nominal_mv[6] = { 2500, 1500, 3300, 5000, 1500, 1500 }; static ssize_t show_in(struct device *dev, struct device_attribute *devattr, char *buf)