From: Ezequiel Garcia Date: Fri, 7 Mar 2014 19:46:45 +0000 (-0300) Subject: dma: mv_xor: Remove unneeded mv_xor_clean_completed_slots() call X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=890766d278548afdc059cd977687c4f1297d72a0;p=openwrt%2Fstaging%2Fblogic.git dma: mv_xor: Remove unneeded mv_xor_clean_completed_slots() call In mv_xor_status(), we are currently calling mv_xor_clean_completed_slots() when the transaction is complete (the cookie status is DMA_COMPLETE). However, a completed status means that mv_xor_slot_cleanup() was called, which cleans the completed slots. In other words, there's nothing to cleanup for a completed transaction in mv_xor_status(). Remove the unneeded call to mv_xor_clean_completed_slots(). Reported-by: Dan Williams Signed-off-by: Ezequiel Garcia Signed-off-by: Dan Williams --- diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index e70f271c99fa..e2c8ec91155e 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -702,10 +702,8 @@ static enum dma_status mv_xor_status(struct dma_chan *chan, enum dma_status ret; ret = dma_cookie_status(chan, cookie, txstate); - if (ret == DMA_COMPLETE) { - mv_xor_clean_completed_slots(mv_chan); + if (ret == DMA_COMPLETE) return ret; - } mv_xor_slot_cleanup(mv_chan); return dma_cookie_status(chan, cookie, txstate);