From: Dan Carpenter <error27@gmail.com>
Date: Thu, 9 Apr 2009 14:09:46 +0000 (+0000)
Subject: ERR_PTR() dereference in net/rds/ib.c
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=94713bab649736177a1c33a39b7bb33cbd5af3a5;p=openwrt%2Fstaging%2Fblogic.git

ERR_PTR() dereference in net/rds/ib.c

rdma_create_id() doesn't return NULL, only ERR_PTR().

Found by smatch (http://repo.or.cz/w/smatch.git).  Compile tested.

regards,
dan carpenter

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/rds/ib.c b/net/rds/ib.c
index 4933b380985e..b9bcd32431e1 100644
--- a/net/rds/ib.c
+++ b/net/rds/ib.c
@@ -224,8 +224,8 @@ static int rds_ib_laddr_check(__be32 addr)
 	 * IB and iWARP capable NICs.
 	 */
 	cm_id = rdma_create_id(NULL, NULL, RDMA_PS_TCP);
-	if (!cm_id)
-		return -EADDRNOTAVAIL;
+	if (IS_ERR(cm_id))
+		return PTR_ERR(cm_id);
 
 	memset(&sin, 0, sizeof(sin));
 	sin.sin_family = AF_INET;