From: Mark Brown Date: Mon, 19 Mar 2012 15:02:31 +0000 (+0000) Subject: OMAPDSS: TPO-TD03MTEA1: Check for errors from regulator_enable() X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=956107eadc27ffbcdf80357e16138f9595f0f4fd;p=openwrt%2Fstaging%2Fblogic.git OMAPDSS: TPO-TD03MTEA1: Check for errors from regulator_enable() It is possible for regulator_enable() to fail and if it does fail that's generally a bad sign for anything we try to do with the hardware afterwards so check for and immediately return an error if regulator_enable() fails. Signed-off-by: Mark Brown Acked-by: Grazvydas Ignotas Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c index 32f3fcd7f0f0..74c6b873932b 100644 --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c @@ -272,11 +272,14 @@ static const struct omap_video_timings tpo_td043_timings = { static int tpo_td043_power_on(struct tpo_td043_device *tpo_td043) { int nreset_gpio = tpo_td043->nreset_gpio; + int r; if (tpo_td043->powered_on) return 0; - regulator_enable(tpo_td043->vcc_reg); + r = regulator_enable(tpo_td043->vcc_reg); + if (r != 0) + return r; /* wait for regulator to stabilize */ msleep(160);