From: Axel Lin Date: Thu, 22 Aug 2013 15:41:34 +0000 (+0800) Subject: spi: Remove a redundant test for master->running in spi_queued_transfer X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=96b3eace39d2ecfdb07003856ddd8f6973dfe7bb;p=openwrt%2Fstaging%2Fblogic.git spi: Remove a redundant test for master->running in spi_queued_transfer We have tested master->running immediately after grab the master->queue_lock. The status of master->running won't be changed until we release the lock. Thus remove a redundant test for master->running. Signed-off-by: Axel Lin Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 978dda2c5239..b1db83f1b4aa 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -774,7 +774,7 @@ static int spi_queued_transfer(struct spi_device *spi, struct spi_message *msg) msg->status = -EINPROGRESS; list_add_tail(&msg->queue, &master->queue); - if (master->running && !master->busy) + if (!master->busy) queue_kthread_work(&master->kworker, &master->pump_messages); spin_unlock_irqrestore(&master->queue_lock, flags);