From: Axel Lin Date: Tue, 19 Feb 2019 10:00:02 +0000 (+0800) Subject: regulator: pv88090: Fix array out-of-bounds access X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=a5455c9159414748bed4678184bf69989a4f7ba3;p=openwrt%2Fstaging%2Fblogic.git regulator: pv88090: Fix array out-of-bounds access Fix off-by-one while iterating current_limits array. The valid index should be 0 ~ n_current_limits -1. Fixes: c90456e36d9c ("regulator: pv88090: new regulator driver") Signed-off-by: Axel Lin Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/pv88090-regulator.c b/drivers/regulator/pv88090-regulator.c index 7a0c15957bd0..2302b0df7630 100644 --- a/drivers/regulator/pv88090-regulator.c +++ b/drivers/regulator/pv88090-regulator.c @@ -157,7 +157,7 @@ static int pv88090_set_current_limit(struct regulator_dev *rdev, int min, int i; /* search for closest to maximum */ - for (i = info->n_current_limits; i >= 0; i--) { + for (i = info->n_current_limits - 1; i >= 0; i--) { if (min <= info->current_limits[i] && max >= info->current_limits[i]) { return regmap_update_bits(rdev->regmap,