From: Holger Hoffstätte Date: Thu, 8 Aug 2019 22:02:40 +0000 (+0200) Subject: r8169: fix performance issue on RTL8168evl X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=a7eb6a4f2560d5ae64bfac98d79d11378ca2de6c;p=openwrt%2Fstaging%2Fblogic.git r8169: fix performance issue on RTL8168evl Disabling TSO but leaving SG active results is a significant performance drop. Therefore disable also SG on RTL8168evl. This restores the original performance. Fixes: 93681cd7d94f ("r8169: enable HW csum and TSO") Signed-off-by: Holger Hoffstätte Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index b2a275d8504c..912bd41eaa1b 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -6898,9 +6898,9 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) /* RTL8168e-vl has a HW issue with TSO */ if (tp->mac_version == RTL_GIGA_MAC_VER_34) { - dev->vlan_features &= ~NETIF_F_ALL_TSO; - dev->hw_features &= ~NETIF_F_ALL_TSO; - dev->features &= ~NETIF_F_ALL_TSO; + dev->vlan_features &= ~(NETIF_F_ALL_TSO | NETIF_F_SG); + dev->hw_features &= ~(NETIF_F_ALL_TSO | NETIF_F_SG); + dev->features &= ~(NETIF_F_ALL_TSO | NETIF_F_SG); } dev->hw_features |= NETIF_F_RXALL;