From: Birger Koblitz Date: Tue, 11 Jan 2022 13:23:23 +0000 (+0100) Subject: realtek: Improve IRQ request in Ethernet driver X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=a82583594277e12d31254697aa6b034f4b59f6f5;p=openwrt%2Fstaging%2Fjow.git realtek: Improve IRQ request in Ethernet driver Improves the IRQ request code by using platform_get_irq() which provides better error handling. Signed-off-by: Birger Koblitz --- diff --git a/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c b/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c index 6db2b2a1fe..84b8a5b943 100644 --- a/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c +++ b/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c @@ -2209,14 +2209,13 @@ static int __init rtl838x_eth_probe(struct platform_device *pdev) spin_lock_init(&priv->lock); - /* obtain device IRQ number */ - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); - if (!res) { + /* Obtain device IRQ number */ + dev->irq = platform_get_irq(pdev, 0); + if (dev->irq < 0) { dev_err(&pdev->dev, "cannot obtain IRQ, using default 24\n"); dev->irq = 24; - } else { - dev->irq = res->start; } + dev->ethtool_ops = &rtl838x_ethtool_ops; dev->min_mtu = ETH_ZLEN; dev->max_mtu = 1536;