From: Arvind Yadav Date: Fri, 24 Nov 2017 17:01:40 +0000 (+0530) Subject: power: supply: cpcap-battery: Fix platform_get_irq_byname's error checking X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=aac799040731ee338b84d27c27fa2d903e89c857;p=openwrt%2Fstaging%2Fblogic.git power: supply: cpcap-battery: Fix platform_get_irq_byname's error checking The platform_get_irq_byname() function returns -1 if an error occurs. zero or positive number on success. platform_get_irq_byname() error checking for zero is not correct. Signed-off-by: Arvind Yadav Signed-off-by: Sebastian Reichel --- diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c index ee71a2b37b12..98ba07869c3b 100644 --- a/drivers/power/supply/cpcap-battery.c +++ b/drivers/power/supply/cpcap-battery.c @@ -586,8 +586,8 @@ static int cpcap_battery_init_irq(struct platform_device *pdev, int irq, error; irq = platform_get_irq_byname(pdev, name); - if (!irq) - return -ENODEV; + if (irq < 0) + return irq; error = devm_request_threaded_irq(ddata->dev, irq, NULL, cpcap_battery_irq_thread,