From: Ville Syrjälä Date: Wed, 10 Jul 2019 13:49:37 +0000 (+0300) Subject: drm/i915: Don't pass stack garbage to pcode in the second data register X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=b12d5944fc285730d75bdd8f7cbc28d22c26f36f;p=openwrt%2Fstaging%2Fblogic.git drm/i915: Don't pass stack garbage to pcode in the second data register Zero initialize val2 so that we don't pass stack garbage to the pcode qgv read command. I suspect in this case pcode just ignores the initial value in that registers, but better safe than sorry. Cc: Dan Carpenter Reported-by: Dan Carpenter Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20190710134937.25835-1-ville.syrjala@linux.intel.com Reviewed-by: Chris Wilson --- diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c index 7b908e10d32e..ee52c5b4643b 100644 --- a/drivers/gpu/drm/i915/display/intel_bw.c +++ b/drivers/gpu/drm/i915/display/intel_bw.c @@ -65,7 +65,7 @@ static int icl_pcode_read_qgv_point_info(struct drm_i915_private *dev_priv, struct intel_qgv_point *sp, int point) { - u32 val = 0, val2; + u32 val = 0, val2 = 0; int ret; ret = sandybridge_pcode_read(dev_priv,