From: Linus Torvalds Date: Wed, 5 Jul 2017 20:03:05 +0000 (-0700) Subject: Cavium CNN55XX: fix broken default Kconfig entry X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=b4b8cbf679c4866a523a35d1454884a31bd5d8dc;p=openwrt%2Fstaging%2Fblogic.git Cavium CNN55XX: fix broken default Kconfig entry Every developer always thinks that _their_ code is so special and magical that it should be enabled by default. And most of them are completely and utterly wrong. That's definitely the case when you write a specialty driver for a very unsual "security processor". It does *not* get to mark itself as "default m". If you solve world hunger, and make a driver that cures people of cancer, by all means enable it by default. But afaik, the Cavium CNN55XX does neither. Signed-off-by: Linus Torvalds --- diff --git a/drivers/crypto/cavium/nitrox/Kconfig b/drivers/crypto/cavium/nitrox/Kconfig index 731e6a57218a..181a1dfec932 100644 --- a/drivers/crypto/cavium/nitrox/Kconfig +++ b/drivers/crypto/cavium/nitrox/Kconfig @@ -12,7 +12,6 @@ config CRYPTO_DEV_NITROX_CNN55XX tristate "Support for Cavium CNN55XX driver" depends on PCI_MSI && 64BIT select CRYPTO_DEV_NITROX - default m help Support for Cavium NITROX family CNN55XX driver for accelerating crypto workloads.