From: Finn Thain <fthain@telegraphics.com.au>
Date: Wed, 12 Sep 2018 00:18:44 +0000 (-0400)
Subject: macintosh/via-macii: Synchronous bus reset
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=b52dce87389385aad54f5680329b41257ee0f7ac;p=openwrt%2Fstaging%2Fblogic.git

macintosh/via-macii: Synchronous bus reset

Make the reset operation synchronous, like the other ADB drivers.
The reset request is static data but callers may not know that.
This way the struct is not in use when the reset method returns.

Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---

diff --git a/drivers/macintosh/via-macii.c b/drivers/macintosh/via-macii.c
index cf6f7d52d6be..36a4f49e79b5 100644
--- a/drivers/macintosh/via-macii.c
+++ b/drivers/macintosh/via-macii.c
@@ -331,7 +331,8 @@ static int macii_reset_bus(void)
 		return 0;
 
 	/* Command = 0, Address = ignored */
-	adb_request(&req, NULL, 0, 1, ADB_BUSRESET);
+	adb_request(&req, NULL, ADBREQ_NOSEND, 1, ADB_BUSRESET);
+	macii_send_request(&req, 1);
 
 	/* Don't want any more requests during the Global Reset low time. */
 	udelay(3000);