From: Rosen Penev <rosenp@gmail.com>
Date: Thu, 15 Oct 2020 05:58:26 +0000 (-0700)
Subject: base-files: functions.sh: replace [^...] with [!...] in case
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=b9246bbdc9a97041c5573845a7858ef3b1c54ff2;p=openwrt%2Fstaging%2Faparcar.git

base-files: functions.sh: replace [^...] with [!...] in case

Strictly speaking, ash does not support it.

From https://wiki.ubuntu.com/DashAsBinSh#A.5B.5E.5D

Not to be confused by sed's and other program's regular expression
syntax. Uses of [^...] in case (parameter/word expansion in general) need
to be replaced with [!...].

Found with shellcheck: https://github.com/koalaman/shellcheck/wiki/SC2169

Signed-off-by: Rosen Penev <rosenp@gmail.com>
[minor commit title/message adjustments]
Signed-off-by: Adrian Schmutzler <freifunk@adrianschmutzler.de>
---

diff --git a/package/base-files/files/lib/functions.sh b/package/base-files/files/lib/functions.sh
index 7da0c872fa..ee4ad1af83 100755
--- a/package/base-files/files/lib/functions.sh
+++ b/package/base-files/files/lib/functions.sh
@@ -108,7 +108,7 @@ config_unset() {
 # config_get <section> <option>
 config_get() {
 	case "$2${3:-$1}" in
-		*[^A-Za-z0-9_]*) : ;;
+		*[!A-Za-z0-9_]*) : ;;
 		*)
 			case "$3" in
 				"") eval echo "\"\${CONFIG_${1}_${2}:-\${4}}\"";;