From: Ralf Baechle Date: Wed, 24 Feb 2010 16:41:00 +0000 (+0100) Subject: MIPS: Cobalt: Fix theoretical port aliasing issue X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=b9b37787d24cca9fbd63f767663e9439fa69aa22;p=openwrt%2Fstaging%2Fblogic.git MIPS: Cobalt: Fix theoretical port aliasing issue Because the VIA SuperIO chip only decodes 24 bits of address space but port address space currently being configured as 32MB there is the theoretical possibility of aliases within the I/O port address range. The complicated solution is to reserve all address range that potencially could cause such aliases. But with the PCI spec limiting port allocations for devices to a maximum of 256 bytes 16MB of port address space already is way more than one would ever expect to be used so we just reduce the port space to 16MB. Signed-off-by: Ralf Baechle To: Yoichi Yuasa Cc: Bjorn Helgaas Cc: linux-mips@linux-mips.org Cc: Benjamin Herrenschmidt Patchwork: http://patchwork.linux-mips.org/patch/995/ --- diff --git a/arch/mips/cobalt/pci.c b/arch/mips/cobalt/pci.c index cfce7af1bca9..85ec9cc31d66 100644 --- a/arch/mips/cobalt/pci.c +++ b/arch/mips/cobalt/pci.c @@ -25,7 +25,7 @@ static struct resource cobalt_mem_resource = { static struct resource cobalt_io_resource = { .start = 0x1000, - .end = GT_DEF_PCI0_IO_SIZE - 1, + .end = 0xffffffUL, .name = "PCI I/O", .flags = IORESOURCE_IO, };