From: Andy Shevchenko Date: Mon, 3 Nov 2014 17:29:23 +0000 (+0200) Subject: mfd: lpc_sch: Don't call mfd_remove_devices() X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=bde3e706a63d5c258b3e4f5e327bcf032fb1adfe;p=openwrt%2Fstaging%2Fblogic.git mfd: lpc_sch: Don't call mfd_remove_devices() MFD core already cares about failing registration. It will remove successfully registered devices in case of error. Thus, no need to repeatedly call mfd_remove_devices(). Fixes: 5829e9b64e65 (mfd: lpc_sch: Accomodate partial population of the MFD devices) Signed-off-by: Andy Shevchenko Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/lpc_sch.c b/drivers/mfd/lpc_sch.c index c980da479a35..5c38df35a84d 100644 --- a/drivers/mfd/lpc_sch.c +++ b/drivers/mfd/lpc_sch.c @@ -193,11 +193,7 @@ static int lpc_sch_probe(struct pci_dev *dev, const struct pci_device_id *id) return -ENODEV; } - ret = mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, NULL); - if (ret) - mfd_remove_devices(&dev->dev); - - return ret; + return mfd_add_devices(&dev->dev, 0, lpc_sch_cells, cells, NULL, 0, NULL); } static void lpc_sch_remove(struct pci_dev *dev)