From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 12 Dec 2017 18:30:29 +0000 (-0800)
Subject: skge: remove redundunt free_irq under spinlock
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=c009cb842fcc0f84536a9d2692e6f063af5ac5c6;p=openwrt%2Fstaging%2Fblogic.git

skge: remove redundunt free_irq under spinlock

The code to handle multi-port SKGE boards was freeing IRQ
twice. The first one was under lock and might sleep.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index 6e423f098a60..31efc47c847e 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -4081,7 +4081,6 @@ static void skge_remove(struct pci_dev *pdev)
 	if (hw->ports > 1) {
 		skge_write32(hw, B0_IMSK, 0);
 		skge_read32(hw, B0_IMSK);
-		free_irq(pdev->irq, hw);
 	}
 	spin_unlock_irq(&hw->hw_lock);