From: Takashi Iwai Date: Wed, 27 Jun 2018 12:59:00 +0000 (+0200) Subject: ALSA: intel_hdmi: Use strlcpy() instead of strncpy() X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=c288248f5b26cd5563112fcdc077bf44964a942d;p=openwrt%2Fstaging%2Fblogic.git ALSA: intel_hdmi: Use strlcpy() instead of strncpy() hdmi_lpe_audio_probe() copies the pcm name string via strncpy(), but as a gcc8 warning suggests, it misses a NUL terminator, and unlikely the expected result. Use the proper one, strlcpy() instead. Signed-off-by: Takashi Iwai --- diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c index 4ed9d0c41843..edc9f5a34eff 100644 --- a/sound/x86/intel_hdmi_audio.c +++ b/sound/x86/intel_hdmi_audio.c @@ -1854,7 +1854,7 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev) /* setup private data which can be retrieved when required */ pcm->private_data = ctx; pcm->info_flags = 0; - strncpy(pcm->name, card->shortname, strlen(card->shortname)); + strlcpy(pcm->name, card->shortname, strlen(card->shortname)); /* setup the ops for playabck */ snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &had_pcm_ops);