From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 28 Jul 2017 14:41:11 +0000 (+0300)
Subject: Bluetooth: btrtl: Fix a error code in rtl_load_config()
X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=c3327bde514d5945f5de1e28bed3eaa0c4d622ec;p=openwrt%2Fstaging%2Fblogic.git

Bluetooth: btrtl: Fix a error code in rtl_load_config()

We accidentally return success if the kmemdup() fails.  It results in
a NULL dereference in the caller.

Fixes: 1110a2dbe698 ("Bluetooth: btrtl: Add RTL8822BE Bluetooth device")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
---

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 8279094dd713..d9a99b4302ea 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -279,6 +279,8 @@ static int rtl_load_config(struct hci_dev *hdev, const char *name, u8 **buff)
 		return ret;
 	ret = fw->size;
 	*buff = kmemdup(fw->data, ret, GFP_KERNEL);
+	if (!*buff)
+		ret = -ENOMEM;
 
 	release_firmware(fw);