From: Nicolas Saenz Julienne Date: Fri, 21 Dec 2018 19:25:18 +0000 (+0000) Subject: firmware: arm_sdei: fix wrong of_node_put() in init function X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=c3790b3799f8d75d93d26f6fd7bb569fc8c8b0cb;p=openwrt%2Fstaging%2Fblogic.git firmware: arm_sdei: fix wrong of_node_put() in init function After finding a "firmware" dt node arm_sdei tries to match it's compatible string with it. To do so it's calling of_find_matching_node() which already takes care of decreasing the refcount on the "firmware" node. We are then incorrectly decreasing the refcount on that node again. This patch removes the unwarranted call to of_node_put(). Signed-off-by: Nicolas Saenz Julienne Signed-off-by: James Morse Signed-off-by: Will Deacon --- diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c index 1ea71640fdc2..dffb47c6b480 100644 --- a/drivers/firmware/arm_sdei.c +++ b/drivers/firmware/arm_sdei.c @@ -1017,7 +1017,6 @@ static bool __init sdei_present_dt(void) return false; np = of_find_matching_node(fw_np, sdei_of_match); - of_node_put(fw_np); if (!np) return false;