From: kbuild test robot Date: Tue, 24 Oct 2017 16:33:18 +0000 (+0800) Subject: usb: xhci-mtk: fix ptr_ret.cocci warnings X-Git-Url: http://git.cdn.openwrt.org/?a=commitdiff_plain;h=c929d84735bff4349bde809a5a8eb1996bf371f6;p=openwrt%2Fstaging%2Fblogic.git usb: xhci-mtk: fix ptr_ret.cocci warnings drivers/usb/host/xhci-mtk.c:256:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: b6bb72cf0df1 ("usb: xhci-mtk: add optional mcu and dma bus clocks") Signed-off-by: Fengguang Wu Acked-by: Chunfeng Yun Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c index e5caabe7eebe..19d27ce31fdc 100644 --- a/drivers/usb/host/xhci-mtk.c +++ b/drivers/usb/host/xhci-mtk.c @@ -253,10 +253,7 @@ static int xhci_mtk_clks_get(struct xhci_hcd_mtk *mtk) return PTR_ERR(mtk->mcu_clk); mtk->dma_clk = optional_clk_get(dev, "dma_ck"); - if (IS_ERR(mtk->dma_clk)) - return PTR_ERR(mtk->dma_clk); - - return 0; + return PTR_ERR_OR_ZERO(mtk->dma_clk); } static int xhci_mtk_clks_enable(struct xhci_hcd_mtk *mtk)